Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: narrow the auth event listening (Sourcery refactored) #574

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Sep 29, 2023

Pull Request #573 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the silentworks/narrow-auth-events-listening branch, then run:

git fetch origin sourcery/silentworks/narrow-auth-events-listening
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aldas Martti T.
@sourcery-ai sourcery-ai bot force-pushed the sourcery/silentworks/narrow-auth-events-listening branch from 2fff3e4 to 474dc54 Compare September 29, 2023 01:32
if event == "SIGNED_IN" or event == "TOKEN_REFRESHED" or event == "SIGNED_OUT":
if event in ["SIGNED_IN", "TOKEN_REFRESHED", "SIGNED_OUT"]:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Client._listen_to_auth_events refactored with the following changes:

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a098bc4) 71.95% compared to head (474dc54) 71.95%.

Additional details and impacted files
@@                            Coverage Diff                            @@
##           silentworks/narrow-auth-events-listening     #574   +/-   ##
=========================================================================
  Coverage                                     71.95%   71.95%           
=========================================================================
  Files                                             9        9           
  Lines                                           189      189           
=========================================================================
  Hits                                            136      136           
  Misses                                           53       53           
Files Coverage Δ
supabase/client.py 72.61% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks silentworks merged commit 5e5b1e4 into silentworks/narrow-auth-events-listening Sep 29, 2023
@silentworks silentworks deleted the sourcery/silentworks/narrow-auth-events-listening branch February 28, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant