Skip to content

feat: methods for signed url uploads #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Conversation

anand2312
Copy link
Contributor

@anand2312 anand2312 commented Jun 11, 2023

This PR

  • adds a create_signed_upload_url method
  • adds a upload_to_signed_url method
  • adds documentation for typed dicts used in the library for headers/responses
  • closes Storage uploads do not have cache-control header #63 by setting the cache-control header correctly during uploads

(part of #84)

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.34 ⚠️

Comparison is base (e5df2ff) 85.71% compared to head (2b65b0e) 85.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   85.71%   85.38%   -0.34%     
==========================================
  Files          12       12              
  Lines         371      431      +60     
==========================================
+ Hits          318      368      +50     
- Misses         53       63      +10     
Impacted Files Coverage Δ
storage3/_async/file_api.py 84.48% <82.14%> (-0.75%) ⬇️
storage3/_sync/file_api.py 84.48% <82.14%> (-0.75%) ⬇️
storage3/types.py 95.74% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anand2312 anand2312 requested a review from J0 June 11, 2023 17:33
@anand2312 anand2312 linked an issue Jun 11, 2023 that may be closed by this pull request
@anand2312 anand2312 requested a review from dreinon June 12, 2023 07:46
@anand2312 anand2312 merged commit d4757d2 into main Jun 12, 2023
@anand2312 anand2312 deleted the anand/sign-upload-urls branch September 29, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage uploads do not have cache-control header
3 participants