Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse_auth_response to handle cases when data is an empty dictio… #261

Merged
merged 2 commits into from
May 22, 2023

Conversation

hgseo16
Copy link
Contributor

@hgseo16 hgseo16 commented Apr 17, 2023

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Currently, the parse_auth_response() function in helpers.py throws a validation error when it's argument data is an empty dictionary {}.

image

What is the new behavior?

In the new commit, parse_auth_response() function returns an AuthResponse(user=None, session=None) response when it's argument data is an empty dictionary {}.

supabase-py

Additional context

#231

Help

Hi @J0! I'm having trouble setting up the environment for the repository. If I could get some assistance on this, I'll write the necessary changes to pass the test checks.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…nary
@J0
Copy link
Contributor

J0 commented Apr 18, 2023

Hey @hgseo16,

Sure, happy to help and thanks for flagging this- could you ping me on the Supabase Discord? J0#7392

@hgseo16
Copy link
Contributor Author

hgseo16 commented Apr 20, 2023

Hey @J0 ,

I pinged you on a new post at the Supabase Discord help-and-questions channel for your reference.

There seems to be a similar error going on with the email signup. I can take a look at it too after my environment is set up. I'll also try to document the environment set up process so that future gotrue-py contributors have a reference.

I know you're super busy so I hope I'm not rushing you too much.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (359a003) 37.59% compared to head (f533b92) 37.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     supabase-community/supabase-py#261      +/-   ##
==========================================
+ Coverage   37.59%   37.62%   +0.02%     
==========================================
  Files          25       25              
  Lines        2285     2286       +1     
==========================================
+ Hits          859      860       +1     
  Misses       1426     1426              
Impacted Files Coverage Δ
gotrue/helpers.py 78.72% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hgseo16
Copy link
Contributor Author

hgseo16 commented May 1, 2023

Hi @J0 !

Hope you've been doing well. I'm writing this to let you know that I've finished my commit to this specific issue.
Please let me know if there's anything else I can work on.

Thanks!

@J0
Copy link
Contributor

J0 commented May 1, 2023

Hey @hgseo16,

Apologies for missing your previous comment and thanks for the PR! It looks good to me - feel free to merge whenever. Taking a look at your previous comment. Feel free to take on #321 if you have the bandwidth.

Can take on supabase/supabase-py#234 or supabase/supabase-py#236 too if either are of interest to you at all. Documentation PRs would also be great - if you're keen there's still quite a bit missing in terms of examples (e.g. Reset Password etc)

Let me know!

@hgseo16
Copy link
Contributor Author

hgseo16 commented May 22, 2023

Hi @J0,

I forgot to mention that I don't have merge rights for this repository. There seem to be people waiting for this issue to be fixed so if you could merge and bump it for them it'd be great!

@J0 J0 merged commit 633c4ab into supabase:main May 22, 2023
@J0
Copy link
Contributor

J0 commented May 22, 2023

Thanks for flagging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants