- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse_auth_response to handle cases when data is an empty dictio… #261
Conversation
Hey @hgseo16, Sure, happy to help and thanks for flagging this- could you ping me on the Supabase Discord? J0#7392 |
Hey @J0 , I pinged you on a new post at the Supabase Discord There seems to be a similar error going on with the email signup. I can take a look at it too after my environment is set up. I'll also try to document the environment set up process so that future I know you're super busy so I hope I'm not rushing you too much. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main supabase-community/supabase-py#261 +/- ##
==========================================
+ Coverage 37.59% 37.62% +0.02%
==========================================
Files 25 25
Lines 2285 2286 +1
==========================================
+ Hits 859 860 +1
Misses 1426 1426
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hi @J0 ! Hope you've been doing well. I'm writing this to let you know that I've finished my commit to this specific issue. Thanks! |
Hey @hgseo16, Apologies for missing your previous comment and thanks for the PR! It looks good to me - feel free to merge whenever. Taking a look at your previous comment. Feel free to take on #321 if you have the bandwidth. Can take on supabase/supabase-py#234 or supabase/supabase-py#236 too if either are of interest to you at all. Documentation PRs would also be great - if you're keen there's still quite a bit missing in terms of examples (e.g. Reset Password etc) Let me know! |
Thanks for flagging this! |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently, the
parse_auth_response()
function inhelpers.py
throws a validation error when it's argumentdata
is an empty dictionary{}
.What is the new behavior?
In the new commit,
parse_auth_response()
function returns anAuthResponse(user=None, session=None)
response when it's argumentdata
is an empty dictionary{}
.Additional context
#231
Help
Hi @J0! I'm having trouble setting up the environment for the repository. If I could get some assistance on this, I'll write the necessary changes to pass the test checks.