-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in the inheritance diagrams don't work #2097
Comments
ping @Alex-Ian-Hamilton |
And the original astropy issue: astropy/astropy#4935 though the consensus seems to be this is an upstream issue with Sphinx. Either way, not unique to SunPy. |
If this issue is with Sphinx, we can implement the same using HTML Tag. The link gives an ugly example but same can be implemented with simple HTML. |
This is somewhat related to our automodapi, as apparently it still works with pure sphinx: |
For completeness in cross-referencing: astropy/sphinx-automodapi#48 |
My PR to finally fix this issue: astropy/sphinx-automodapi#152 |
While sphinx-doc/sphinx#10576 will fix in bug in Sphinx, I doubt the bugfix will be backported to releases prior to 5.0. Something in our dependency tree for the docs build is keeping Sphinx back at 4.5. |
I am sure we can work out what is causing that and deal with it. |
The bug fixes have been merged upstream (sphinx-doc/sphinx#10614 and astropy/sphinx-automodapi#172), so will presumably show up in respective new releases, but the inheritance diagrams will continue to be broken in our documentation until our theme no longer pins us to an old version of Sphinx (see sunpy/sunpy-sphinx-theme#188). |
@Cadair has updated the theme, so this issue can finally be closed |
see: http://docs.sunpy.org/en/latest/code_ref/timeseries.html#class-inheritance-diagram
The text was updated successfully, but these errors were encountered: