Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AggregateRel should use grouping references #94

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

srikrishnak
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@18b7daf). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
plan/plan.go 30.23% 30 Missing ⚠️
plan/builders.go 96.77% 2 Missing and 1 partial ⚠️
plan/relations.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage        ?   62.48%           
=======================================
  Files           ?       44           
  Lines           ?    10148           
  Branches        ?        0           
=======================================
  Hits            ?     6341           
  Misses          ?     3523           
  Partials        ?      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@EpsilonPrime EpsilonPrime merged commit e403121 into substrait-io:main Jan 8, 2025
8 checks passed
@srikrishnak srikrishnak deleted the aggregate-rel branch January 8, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants