Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve error message when numbers exceed expected precision #103

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Jan 9, 2025

No description provided.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@be0b09b). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
expr/decimal_util.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage        ?   62.66%           
=======================================
  Files           ?       44           
  Lines           ?    10170           
  Branches        ?        0           
=======================================
  Hits            ?     6373           
  Misses          ?     3513           
  Partials        ?      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EpsilonPrime EpsilonPrime merged commit 8c4fdcb into substrait-io:main Jan 10, 2025
8 checks passed
@EpsilonPrime EpsilonPrime deleted the decimal_limits branch January 10, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants