Support reading UTF16 files #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
reviewed
Aug 14, 2023
To allow this, we need to use a different scanner that ignores the respective BOM bytes possible to occur. This means \xFFEE and \xFEFF since UTF16 can both be little endian or big endian. By default, Windows uses UTF16 little endian. Fixes subosito#25
Bios-Marcel
force-pushed
the
bugfix/ignore_bom_bytes
branch
from
e829ad4
to
2acf70a
Compare
Bios-Marcel
added a commit
to Bios-Marcel/gotenv
that referenced
this pull request
Aug 15, 2023
This was broken in PR subosito#26. Since there was previously no test for this case, I added a regression test.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow this, we need to use a different scanner that ignores the respective BOM bytes possible to occur. This means \xFFEE and \xFEFF since UTF16 can both be little endian or big endian.
By default, Windows uses UTF16 little endian.
Fixes #25