Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run #270

Merged
merged 3 commits into from Apr 2, 2024
Merged

Add dry-run #270

merged 3 commits into from Apr 2, 2024

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Feb 10, 2024

I want dry-run parameter for printing.

@subosito
Copy link
Owner

subosito commented Mar 1, 2024

@kzrnm Any use case for this?

@kzrnm
Copy link
Contributor Author

kzrnm commented Mar 1, 2024

For running version checks during scheduled events. Installation of Flutter is not necessary.

on:
  schedule:
    - cron: '30 5 * * 2,4'
jobs:
  version:
    runs-on: ubuntu-latest
    steps:
      - id: flutter-action
        uses: subosito/flutter-action@v2
        with:
          channel: 'stable'
          dry-run: true
      - run: |
          VERSION=${{ steps.flutter-action.outputs.VERSION }}
          echo $VERSION
          # Compare $VERSION and ${{ inputs.current-version }}
          # Notify version...

@bartekpacia
Copy link
Collaborator

Interesting. So you would want to have notifications about new Flutter versions, right?

Or to auto-rebuild your app when a new Flutter version comes out?

@kzrnm
Copy link
Contributor Author

kzrnm commented Mar 2, 2024

So you would want to have notifications about new Flutter versions, right?

I don't need it if I'm developing alone, but it may be necessary if I'm developing in a team.

@bartekpacia
Copy link
Collaborator

Hi! Thank you for the contribution. Could you add tests and update README to reflect your changes?

@kzrnm
Copy link
Contributor Author

kzrnm commented Mar 31, 2024

Is this test correct?

03fa891

@bartekpacia
Copy link
Collaborator

Yes this is good! I'd also like to see another test that asserts that dart and flutter fail (=are not found) when dry-run: true is passed. Just to make sure that it indeed works.

Please also resolve conflitcts - sorry about that!

@bartekpacia bartekpacia merged commit 44ac965 into subosito:main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants