Set architecture options from runner's architecture #264
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji-1009
force-pushed
the
support_os_arch
branch
from
35ea29f
to
06270ec
Compare
|
Awesome, thanks @koji-1009 👍 |
|
@subosito |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple silicon is now available.
https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/
This makes it necessary in some cases to set arm64 for the architecture option.
There is already an option (Thanks!). However, in most cases x64 is used and the option is missed. Therefore, it is likely that users with Apple silicon will not realize that they need to configure arm64.
To solve the above problem, I added a process to get the appropriate architecture from
runner-archif the option is not set.Thanks for the great tool.