From 5f580642a34085c083f1346c1b66fa3028949671 Mon Sep 17 00:00:00 2001 From: Yuichiro Yamashita Date: Fri, 3 Mar 2023 15:58:03 +0900 Subject: [PATCH 1/6] fix index.d.ts type --- types/stylelint/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/stylelint/index.d.ts b/types/stylelint/index.d.ts index 4ee0b27a75..0f10f6a492 100644 --- a/types/stylelint/index.d.ts +++ b/types/stylelint/index.d.ts @@ -631,5 +631,5 @@ declare module 'stylelint' { const stylelint: PublicApi; - export default stylelint; + export = stylelint; } From db6e87b8f21571a238e2f7a728573c8950e62b12 Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Fri, 3 Mar 2023 16:12:33 +0900 Subject: [PATCH 2/6] Add changelog entry --- .changeset/yellow-dodos-juggle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/yellow-dodos-juggle.md diff --git a/.changeset/yellow-dodos-juggle.md b/.changeset/yellow-dodos-juggle.md new file mode 100644 index 0000000000..b73e33ed1d --- /dev/null +++ b/.changeset/yellow-dodos-juggle.md @@ -0,0 +1,5 @@ +--- +"stylelint": patch +--- + +Fixed: type definition for CommonJS From fb4168ef3bf64b25f18b78e4703a7705620de504 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Fri, 3 Mar 2023 17:27:03 +0900 Subject: [PATCH 3/6] update exports instead of type --- lib/index.js | 2 +- types/stylelint/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/index.js b/lib/index.js index 30d08c3e3a..aadd8b9e2e 100644 --- a/lib/index.js +++ b/lib/index.js @@ -32,4 +32,4 @@ const stylelint = Object.assign(postcssPlugin, { }, }); -module.exports = stylelint; +module.exports = { ...stylelint, default: stylelint }; diff --git a/types/stylelint/index.d.ts b/types/stylelint/index.d.ts index 0f10f6a492..4ee0b27a75 100644 --- a/types/stylelint/index.d.ts +++ b/types/stylelint/index.d.ts @@ -631,5 +631,5 @@ declare module 'stylelint' { const stylelint: PublicApi; - export = stylelint; + export default stylelint; } From 2770acd4870df69086b6ec6f5e3c78bd008b1cf9 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Fri, 3 Mar 2023 17:31:24 +0900 Subject: [PATCH 4/6] add a comment --- lib/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/index.js b/lib/index.js index aadd8b9e2e..c6693b2d2f 100644 --- a/lib/index.js +++ b/lib/index.js @@ -32,4 +32,5 @@ const stylelint = Object.assign(postcssPlugin, { }, }); +// To adjust type for CommonJS, we export the default property. module.exports = { ...stylelint, default: stylelint }; From 9caa8ee428dece2a7880ad2a344166f58204a3b8 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Fri, 3 Mar 2023 19:10:08 +0900 Subject: [PATCH 5/6] it is difficult --- lib/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/index.js b/lib/index.js index c6693b2d2f..d5a5748b1b 100644 --- a/lib/index.js +++ b/lib/index.js @@ -32,5 +32,6 @@ const stylelint = Object.assign(postcssPlugin, { }, }); -// To adjust type for CommonJS, we export the default property. -module.exports = { ...stylelint, default: stylelint }; +module.exports = stylelint; +// @ts-ignore -- To adjust type for CommonJS, we export the default property. +module.exports.default = stylelint; From bdf385ef3d6e1f62b229ed2630f867bacb005d6e Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Fri, 3 Mar 2023 23:35:52 +0900 Subject: [PATCH 6/6] Update changelog entry --- .changeset/yellow-dodos-juggle.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/yellow-dodos-juggle.md b/.changeset/yellow-dodos-juggle.md index b73e33ed1d..ea5f1de373 100644 --- a/.changeset/yellow-dodos-juggle.md +++ b/.changeset/yellow-dodos-juggle.md @@ -2,4 +2,4 @@ "stylelint": patch --- -Fixed: type definition for CommonJS +Fixed: TypeScript error for CommonJS importing