Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor matchesStringOrRegExp() utility #7651

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Refactor matchesStringOrRegExp() utility #7651

merged 1 commit into from
Apr 25, 2024

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

This change aims to improve readability in the matchesStringOrRegExp() utility module.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited

⚠️ No Changeset found

Latest commit: 270bbba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous
Refactor matchesStringOrRegExp() utility
270bbba 
This change aims to improve readability in the `matchesStringOrRegExp()` utility module.
@ybiquitous ybiquitous force-pushed the refactor-matchesStringOrRegExp branch from 0f8ed63 to 270bbba Compare April 25, 2024 15:12
@ybiquitous ybiquitous marked this pull request as ready for review April 25, 2024 15:27
Mouvedia
Mouvedia approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybiquitous ybiquitous merged commit d159c1b into main Apr 25, 2024
17 checks passed
@ybiquitous ybiquitous deleted the refactor-matchesStringOrRegExp branch April 25, 2024 23:24
emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024
@ybiquitous @emmacharp
Refactor matchesStringOrRegExp() utility (stylelint#7651)
350b985 
This change aims to improve readability in the `matchesStringOrRegExp()` utility module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouvedia Mouvedia Mouvedia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @Mouvedia