Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra column in some tables in Rules docs #7632

Merged

Conversation

germanfrelo
Copy link
Contributor

@germanfrelo germanfrelo commented Apr 21, 2024

Which issue, if any, is this issue related to?

None, as it's a documentation fix.

Is there anything in the PR that needs further explanation?

There is an extra column in some tables:

Copy link

changeset-bot bot commented Apr 21, 2024

⚠️ No Changeset found

Latest commit: 87472ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germanfrelo Thanks for the pull request.

@Mouvedia
Copy link
Member

off-topic

@ybiquitous should we create an issue to add a stylelint-config-recommended column?

@germanfrelo
Copy link
Contributor Author

germanfrelo commented Apr 21, 2024

off-topic

@ybiquitous should we create an issue to add a stylelint-config-recommended column?

I think it was removed on purpose in PR #6960.

@ybiquitous
Copy link
Member

@germanfrelo is right. stylelint-config-standard includes stylelint-config-recommended, so adding the recommended config is unneeded.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germanfrelo Thank you! LGTM 👍🏼

@ybiquitous ybiquitous enabled auto-merge (squash) April 22, 2024 00:25
@ybiquitous ybiquitous merged commit 1bcdc8b into stylelint:main Apr 22, 2024
16 checks passed
@Mouvedia
Copy link
Member

@germanfrelo is right. stylelint-config-standard includes stylelint-config-recommended, so adding the recommended config is unneeded.

For the users that extend stylelint-config-recommended, like me, it would be useful.
But it's not important, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants