Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function-calc-no-unspaced-operator false negatives for some math functions #7619

Merged
merged 2 commits into from Apr 18, 2024

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Apr 16, 2024

Which issue, if any, is this issue related to?

#7618

Is there anything in the PR that needs further explanation?

A follow-up PR will be necessary to support these: min, max, hypot, clamp, round, mod, rem, atan2, pow, log.

As it's fixing false negatives, it'd be a minor release, in line with our semantic-versioning policy.

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 2088447

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Can you check my comments?

.changeset/funny-jobs-work.md Outdated Show resolved Hide resolved
lib/rules/function-calc-no-unspaced-operator/README.md Outdated Show resolved Hide resolved
lib/rules/function-calc-no-unspaced-operator/index.mjs Outdated Show resolved Hide resolved
lib/rules/function-calc-no-unspaced-operator/index.mjs Outdated Show resolved Hide resolved
…rator`

 current: `calc`, `sin`, `cos`, `tan`, `exp`, `abs`, `sign`, `asin`, `acos`, `atan`, `sqrt`
 planned: `min`, `max`, `hypot`, `clamp`, `round`, `mod`, `rem`, `atan2`, `pow`, `log`

ref https://www.w3.org/TR/css-values-4/#calc-syntax
@ybiquitous ybiquitous changed the title Add support for some math functions to function-calc-no-unspaced-operator Fix function-calc-no-unspaced-operator false negatives for some math functions Apr 18, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@ybiquitous
Copy link
Member

ybiquitous commented Apr 18, 2024

Feel free to merge approved PRs 👍🏼

EDIT: Please use squash and merge.

@Mouvedia Mouvedia merged commit d06a41e into stylelint:main Apr 18, 2024
15 of 16 checks passed
@Mouvedia Mouvedia deleted the fix-calc-sum branch April 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants