Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-type-no-unknown false positives for experimental and deprecated HTML tags #7612

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

Mouvedia
Copy link
Member

Which issue, if any, is this issue related to?

check the "concrete example" in #7510

Is there anything in the PR that needs further explanation?

compare https://github.com/sindresorhus/html-tags/blob/main/html-tags.json and sindresorhus/html-tags@d3b931e

I chose not to include the previous names of the tag names that I am introducing; we need to settle #7510 first.
e.g. not selectmenu

Copy link

changeset-bot bot commented Apr 14, 2024

🦋 Changeset detected

Latest commit: 9376f8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Thanks for the pull request. Overall LGTM, but I have one question.

.changeset/flat-bananas-hug.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@ybiquitous ybiquitous changed the title Fix selector-type-no-unknown false positives Fix selector-type-no-unknown false positives for experimental and deprecated HTML tags Apr 18, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants