Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-max-attribute end positions #7592

Conversation

romainmenke
Copy link
Member

Which issue, if any, is this issue related to?

See : #6234

Follows the same patterns as : #7518

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 428dbb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mouvedia
Copy link
Contributor

Mouvedia commented Apr 2, 2024

off-topic

I have just realized that selector-max-combinators and selector-max-compound-selectors should have singular AKAs to be consistent with the rest of the selector-max-* rules.

i.e.
selector-max-attribute
selector-max-class
selector-max-id
selector-max-pseudo-class
selector-max-specificity
selector-max-type
selector-max-universal
are all singular.

@romainmenke
Copy link
Member Author

AKAs

Not familiar with the term or abbreviation :)

@Mouvedia
Copy link
Contributor

Mouvedia commented Apr 2, 2024

AKAs

Not familiar with the term or abbreviation :)

Also Known As
i.e. selector-max-combinator and selector-max-compound-selector would be accepted as well

@romainmenke
Copy link
Member Author

Ah, yes, obviously :)
I misread your comment a bit and didn't see how "also known as" fitted into that statement.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@romainmenke romainmenke merged commit 4dd08ea into main Apr 5, 2024
14 checks passed
@romainmenke romainmenke deleted the fix-selector-max-attribute-end-positions--courteous-humpback-whale-e8b7fd189b branch April 5, 2024 05:31
emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024
* Fix `selector-max-attribute` end positions

* fmt

* Create short-cobras-join.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants