Fix import errors for configs and plugins omitting /index.js
#7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7817c16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ota-meshi
changed the title
/index.js could not be loaded/index.js could not be loaded
ybiquitous
changed the title
/index.js could not be loaded
ybiquitous
changed the title
/index.js
ybiquitous
reviewed
Mar 26, 2024
There was a problem hiding this comment.
@ota-meshi Thank you for the quick fix! Overall LGTM, but I've left a few comments. Can you take a look?
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thank you for the suggestions! I've modified this PR. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7576
Closes #7577
Ref #7532
This PR fixes an issue where cannot resolve paths in configurations that expect
index.jsto resolve implicitly by Node.js.