Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue between stylelint@16.3.0 and stylelint-prettier@5.0.0 #7576

Closed
AntoLC opened this issue Mar 25, 2024 · 3 comments · Fixed by #7578
Closed

Compatibility issue between stylelint@16.3.0 and stylelint-prettier@5.0.0 #7576

AntoLC opened this issue Mar 25, 2024 · 3 comments · Fixed by #7578
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@AntoLC
Copy link

AntoLC commented Mar 25, 2024

What minimal example or steps are needed to reproduce the bug?

Having stylelint@16.3.0 and stylelint-prettier@5.0.0 in the same repo.

What minimal configuration is needed to reproduce the bug?

Seems to be a compatibility issue between stylelint@16.3.0 and stylelint-prettier@5.0.0.
Capture d'écran 2024-03-25 104853

How did you run Stylelint?

yarn stylelint

Which Stylelint-related dependencies are you using?

    "stylelint": "16.3.0",
    "stylelint-config-standard": "36.0.0",
    "stylelint-prettier": "5.0.0",

What did you expect to happen?

The linting to work.

What actually happened?

Capture d'écran 2024-03-25 104853

Do you have a proposal to fix the bug?

No response
@AntoLC AntoLC mentioned this issue Mar 25, 2024
Merged
1 task
@ota-meshi ota-meshi mentioned this issue Mar 25, 2024
Merged
1 task
aduth added a commit to 18F/identity-design-system that referenced this issue Mar 25, 2024
@aduth
Downgrade Stylelint
0fc6455 
Compatibility issue with stylelint-prettier in latest version

See: stylelint/stylelint#7576
aduth added a commit to 18F/identity-design-system that referenced this issue Mar 25, 2024
@aduth
Prepare 9.1.0 release (#436)
948b332 
* Bump dependencies to latest

* Prepare 9.1.0 release

* Bump dependencies

* Downgrade Stylelint

Compatibility issue with stylelint-prettier in latest version

See: stylelint/stylelint#7576

* Reset and reinstall lockfile from main

Avoid stylelint upgrade
This was referenced Mar 25, 2024
Merged
Closed
@Mouvedia Mouvedia added the status: needs investigation triage needs further investigation label Mar 25, 2024
@Mouvedia
Copy link
Member

Mouvedia commented Mar 25, 2024 •
edited

#7532 is probably the culprit.
@ybiquitous this needs to be investigated.
If I had to guess, I would say it has something to do with the getModulePath call inside absolutizePaths.

@BlackySoul BlackySoul mentioned this issue Mar 25, 2024
Closed
@stopfstedt stopfstedt mentioned this issue Mar 25, 2024
Closed
This was referenced Mar 26, 2024
Closed
Merged
@ybiquitous
Copy link
Member

Thanks for the report. Right, we should fix the error as soon as possible. I'll review the PR to try fixing it.

@ybiquitous ybiquitous added status: wip is being worked on by someone type: bug a problem with a feature or rule and removed status: needs investigation triage needs further investigation labels Mar 26, 2024
@ybiquitous ybiquitous mentioned this issue Mar 26, 2024
Closed
@ybiquitous
Copy link
Member

For your information, here's a reproducible demo, which raises:

Directory import '/home/httpschimericaltrifle8d3c21net-1ell/node_modules/stylelint-prettier/' is not supported resolving ES modules imported from /home/httpschimericaltrifle8d3c21net-1ell/node_modules/stylelint/lib/utils/dynamicImport.mjs
Did you mean to import /home/httpschimericaltrifle8d3c21net-1ell/node_modules/stylelint-prettier/index.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import errors for configs and plugins omitting /index.js stylelint/stylelint
3 participants
@Mouvedia @ybiquitous @AntoLC