New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rule-selector-property-disallowed-list
false positives for nesting selectors
#7558
Conversation
🦋 Changeset detectedLatest commit: 1c6b2a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@romainmenke Thank you for the pull request! This is just an idea, but how about resolving and flattening selectors like #7518? |
Umm... I realized that this way is problematic, as #7557 describes. |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…alse-positives-for-nesting-selectors--intuitive-indian-palm-squirrel-030052a111
Thank you for the review @ybiquitous 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
Closes #7488
I noticed that this walks down the entire sub tree for each rule node.
This might not be what users expect.
But changing it to
.each()
also has issues.It will no longer give errors on :
Edit: I've found a more complete patch