Refactor Cosmiconfig types #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Allowing the `CosmiconfigResult` type to receive a type parameter can make the code a bit type-safer because the `any` type is no longer used. Ref https://github.com/cosmiconfig/cosmiconfig/blob/v9.0.0/src/types.ts#L11 Note this change includes a patch for the type defined in the `cosmiconfig` package.
ybiquitous
force-pushed
the
refactor-cosmiconfig-types
branch
from
8ce0237
to
405a43c
Compare
|
I just transitioned this PR to ready for review because this patch benefits. I would be happy if someone could take a look. 🙏🏼 |
|
There is no review yet, but I believe this helps detect issues like 9c7bbe3. So I'll merge this. |
ybiquitous
added a commit
that referenced
this pull request
Apr 27, 2024
This reverts commit 9afaa08.
emmacharp
pushed a commit
to emmacharp/stylelint
that referenced
this pull request
May 7, 2024
Allowing the `CosmiconfigResult` type to receive a type parameter can make the code a bit type-safer because the `any` type is no longer used. Ref https://github.com/cosmiconfig/cosmiconfig/blob/v9.0.0/src/types.ts#L11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.
Allowing the
CosmiconfigResulttype to receive a type parameter can make the code a bit type-safer because theanytype is no longer used.Ref https://github.com/cosmiconfig/cosmiconfig/blob/v9.0.0/src/types.ts#L11
Note this change includes a patch for the type defined in the
cosmiconfigpackage. I will open a pull request in the package repository soon.Wait for fix: accept type parameter forCosmiconfigResultcosmiconfig/cosmiconfig#343Let's proceed without waiting since there is no response to the PR above. When Cosmiconfig ships a new version, then we can remove this patch.