Add media-query-no-invalid specific problem messages
#7462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cc80c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mouvedia
reviewed
Jan 14, 2024
|
@romainmenke Thanks for the pull request!
As far as I know, there is no such case. But I think what this PR try is not a problem. 👌🏼
I prefer
I think so, too. Your try looks good to me. 👍🏼 |
ybiquitous
reviewed
Jan 14, 2024
…pe-71a22d3c66' of https://github.com/stylelint/stylelint into media-query-no-invalid--specific-messages--witty-antelope-71a22d3c66
romainmenke
commented
Jan 14, 2024
|
Thank you for the feedback @Mouvedia, @ybiquitous 🙇 |
ybiquitous
reviewed
Jan 15, 2024
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
approved these changes
Jan 15, 2024
romainmenke
deleted the
media-query-no-invalid--specific-messages--witty-antelope-71a22d3c66
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7401
I've added a second argument for the
rejectedmessage.hinta good name for the second argument? (maybereason, ...)I am also unsure what the best wording is.
I don't think most people are familiar with the wording of the specification, e.g.
range context,plain feature, ...So I've opted to label everything as a query :
range query,boolean query.