Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document benefits from TypeScript annotation #7423

Merged
merged 4 commits into from
Dec 24, 2023
Merged

Document benefits from TypeScript annotation #7423

merged 4 commits into from
Dec 24, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #7072

Is there anything in the PR that needs further explanation?

See https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html

This comment was marked as resolved.

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mouvedia
Copy link
Member

Correct me if I am wrong, but this PR is just one part of #7072.
i.e. it doesn't close it

Co-authored-by: Marc G. <Mouvedia@users.noreply.github.com>
@ybiquitous
Copy link
Member Author

Correct me if I am wrong, but this PR is just one part of #7072.

I think the current changes are enough, but more suggestions may come. Let's wait.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reword it to make it simpler.

docs/developer-guide/plugins.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
ybiquitous and others added 2 commits December 22, 2023 09:38
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ybiquitous ybiquitous mentioned this pull request Dec 22, 2023
9 tasks
@ybiquitous ybiquitous merged commit e222352 into main Dec 24, 2023
16 checks passed
@ybiquitous ybiquitous deleted the issue-7072 branch December 24, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document how to write plugins using TypeScript
4 participants