Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some TODOs #7234

Merged
merged 1 commit into from Oct 17, 2023
Merged

Remove some TODOs #7234

merged 1 commit into from Oct 17, 2023

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Oct 14, 2023

Which issue, if any, is this issue related to?

see tasklist on #7060

Is there anything in the PR that needs further explanation?

I didn't tick the review because I couldn't resolve all the TODOs; 6 files are left:

  • lib/rules/functionCommaSpaceChecker.js
  • lib/rules/color-named/index.js
  • lib/rules/selector-class-pattern/index.js
  • lib/rules/selector-descendant-combinator-no-non-space/index.js
  • lib/rules/string-quotes/index.js
  • v16:
    • lib/formatters/__tests__/terminalLink.test.mjs
    • .github/dependabot.yml

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2023

⚠️ No Changeset found

Latest commit: 6b9141e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Thanks for the pull request. I've commented on string-quotes, but LGTM for others 👍🏼

@Mouvedia
Copy link
Contributor Author

@ybiquitous Ill leave the v16 related ones for you to clean up :)

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@ybiquitous ybiquitous mentioned this pull request Oct 16, 2023
4 tasks
@ybiquitous ybiquitous merged commit 9941121 into stylelint:main Oct 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants