Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new testRuleConfigs function of jest-preset-stylelint #7124

Merged
merged 3 commits into from Aug 10, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Aug 10, 2023

Which issue, if any, is this issue related to?

Ref stylelint/jest-preset-stylelint#68

Is there anything in the PR that needs further explanation?

Note that this PR uses the unpublished version of jest-preset-stylelint.
The new version is out! https://github.com/stylelint/jest-preset-stylelint/releases/tag/6.2.0

@changeset-bot

This comment was marked as resolved.

@ybiquitous ybiquitous marked this pull request as ready for review August 10, 2023 13:29
@ybiquitous ybiquitous changed the title Use invalidConfig property of jest-preset-stylelint new feature Use new testRuleConfigs function of jest-preset-stylelint Aug 10, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Is the intent to add this to other rules or keep it in our back pocket to use when fixing a bug with the option validation of a rule?

@ybiquitous
Copy link
Member Author

Is the intent to add this to other rules or keep it in our back pocket to use when fixing a bug with the option validation of a rule?

I think the latter now. But adding this to other rules may be good when we have time. 👍🏼

@ybiquitous ybiquitous merged commit 83a3e2b into main Aug 10, 2023
16 checks passed
@ybiquitous ybiquitous deleted the jest-preset-stylelint-invalidConfig branch August 10, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants