Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-element-no-unknown false positives for view-transition pseudo-elements #7070

Merged
merged 5 commits into from Jul 10, 2023

Conversation

danielroe
Copy link
Contributor

Which issue, if any, is this issue related to?

Resolves #7069

Is there anything in the PR that needs further explanation?

No, it's self-explanatory. I've added some details in the linked issue.

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

🦋 Changeset detected

Latest commit: 6b7a5cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeddy3 jeddy3 changed the title Support view-transition pseudo-elements Fix selector-pseudo-element-no-unknown false positives for view-transition pseudo-elements Jul 10, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@danielroe
Copy link
Contributor Author

🤝

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe Thanks for your first-time contribution! LGTM 👍🏼

I've suggested a minor point, but we can merge this as it is.

lib/reference/selectors.js Outdated Show resolved Hide resolved
lib/reference/selectors.js Outdated Show resolved Hide resolved
lib/reference/selectors.js Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏼

@ybiquitous ybiquitous merged commit 6765374 into stylelint:main Jul 10, 2023
16 checks passed
@danielroe danielroe deleted the fix/view-transitions branch July 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix selector-pseudo-element-no-unknown false positives for view-transition pseudo-elements
3 participants