Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document check of configs in release process #7047

Merged
merged 3 commits into from Jul 5, 2023
Merged

Document check of configs in release process #7047

merged 3 commits into from Jul 5, 2023

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jul 5, 2023

Which issue, if any, is this issue related to?

Closes #7045

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

(Diff is mainly whitespace for test.)

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023 •
edited

⚠️ No Changeset found

Latest commit: 7383d31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ybiquitous
ybiquitous approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👍🏼

I've suggested two, but they're minor. You can ignore them.

docs/maintainer-guide/releases.md Outdated Show resolved Hide resolved
lib/rules/__tests__/index.test.mjs Outdated Show resolved Hide resolved
jeddy3 and others added 2 commits July 5, 2023 14:13
@jeddy3 @ybiquitous
Update lib/rules/__tests__/index.test.mjs
3bb8040 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 @ybiquitous
Update docs/maintainer-guide/releases.md
7383d31 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit 8090553 into main Jul 5, 2023
18 checks passed
@jeddy3 jeddy3 deleted the issue-7045 branch July 5, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document check of configs in release process
2 participants
@jeddy3 @ybiquitous