Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document check of configs in release process #7045

Closed
jeddy3 opened this issue Jul 4, 2023 · 2 comments · Fixed by #7047
Closed

Document check of configs in release process #7045

jeddy3 opened this issue Jul 4, 2023 · 2 comments · Fixed by #7047
Labels
status: wip is being worked on by someone type: documentation an improvement to the documentation

Comments

@jeddy3
Copy link
Member

jeddy3 commented Jul 4, 2023

Ref: #7044

We have a chicken and egg problem. Our test in this repo will fail if we mark a rule as included in the standard config before releasing it. If we wait until after realising the config then the tests on main will fail.

We also have to mark it as included before releasing the config as we use a tarball version of this package for the website.

Any ideas on how to resolve this or do we need to remove this test?
@jeddy3 jeddy3 added the status: needs discussion triage needs further discussion label Jul 4, 2023
@ybiquitous
Copy link
Member

Oh, I didn't realize that problem. 😓

How about skipping the problematic case by default and running it as needed by a temporary manual change? It's not smart, though...

@jeddy3
Copy link
Member Author

jeddy3 commented Jul 5, 2023

How about skipping the problematic case by default and running it as needed by a temporary manual change?

SGTM.

We also have to mark it as included before releasing the config as we use a tarball version of this package for the website.

I'll open a PR to document this.

@jeddy3 jeddy3 changed the title Release process and the rules table Document check of configs in release process Jul 5, 2023
@jeddy3 jeddy3 added status: wip is being worked on by someone type: documentation an improvement to the documentation and removed status: needs discussion triage needs further discussion labels Jul 5, 2023
@jeddy3 jeddy3 mentioned this issue Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone type: documentation an improvement to the documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document check of configs in release process stylelint/stylelint
2 participants
@ybiquitous @jeddy3