New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removed changelog entry #7039
Conversation
|
Good to know 🙇 This was initially : Fixed: remove `postcss-media-query-parser` dependency Should it be reverted to that? |
I don't think so. It's not user-facing, and "Fixed: remove" will be inconsistent with the other entries in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Um... I acknowledge the inconsistency, but will not PR #6999 affect people, especially plugin authors using I think we should inform people about the removed dependency in some way. Any thoughts? |
I don't think we need to as those changes were a refactor that didn't change our public API (for consumers and plugin authors). However, how about we include a second tweet as part of the release to let people know about and draw attention to the new parser? Something along the lines of: "Under the hood, we've replaced our media query parser with @romainmenke's more modern and spec-compliant one. If you're a plugin author targeting media queries, we recommend using this parser too: https://www.npmjs.com/package/@csstools/media-query-list-parser" That way people are informed and the changelog remains for our public API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. 👍🏼
None.
We've consistently followed the conventions of:
This pull request removes the inconsistent changelog entry, which isn't user-facing and is "patch" for "Removed".