Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media-query-no-invalid #6963

Merged
merged 10 commits into from Jun 25, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 23, 2023

Which issue, if any, is this issue related to?

Closes #6916

Is there anything in the PR that needs further explanation?

I've added some comments where I thought further explanation might be needed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: e28036e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romainmenke Thanks for the pull request. This is fantastic work!

I've commented a few on trivial things, but I believe there're no big problems 👍🏼

docs/user-guide/rules.md Outdated Show resolved Hide resolved
lib/rules/index.js Outdated Show resolved Hide resolved
lib/rules/media-query-no-invalid/index.js Outdated Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍🏼

@romainmenke romainmenke merged commit 5abe468 into main Jun 25, 2023
18 checks passed
@romainmenke romainmenke deleted the add-media-query-no-invalid--amiable-lynx-a9e08fec44 branch June 25, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add media-query-no-invalid
3 participants