Fix function-no-unknown false positives for SCSS functions with namespace
#6921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56e0ee6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
romainmenke
changed the title
function-no-unknown false positives for SCSS functions with nam…function-no-unknown false positives for SCSS functions with namespace
ybiquitous
approved these changes
Jun 16, 2023
romainmenke
deleted the
Fix-function-no-unknown-false-positives-for-SCSS-functions-with-namespace
branch
ybiquitous
added a commit
to ybiquitous/stylelint-scss
that referenced
this pull request
Nov 30, 2023
Since Stylelint 15.8.0, the built-in `function-no-unknown` rule has ignored SCSS functions with namespace.
For example, the following code unexpectedly passes with Stylelint 15.8.0:
```scss
a { color: color.unknown(#fff); }
```
Notes:
- This change keeps backward compatibility. This means not to change `peerDependencies.stylelint` in `package.json`.
- This change may bring performance penalty to keep backward compatibility.
- Run `npm i 'stylelint@^15.8.0' && npm t` to test this change with newer versions of Stylelint.
See also:
- https://github.com/stylelint/stylelint/releases/tag/15.8.0
- stylelint/stylelint#6921
kristerkari
pushed a commit
to stylelint-scss/stylelint-scss
that referenced
this pull request
Dec 8, 2023
#888) Since Stylelint 15.8.0, the built-in `function-no-unknown` rule has ignored SCSS functions with namespace. For example, the following code unexpectedly passes with Stylelint 15.8.0: ```scss a { color: color.unknown(#fff); } ``` Notes: - This change keeps backward compatibility. This means not to change `peerDependencies.stylelint` in `package.json`. - This change may bring performance penalty to keep backward compatibility. - Run `npm i 'stylelint@^15.8.0' && npm t` to test this change with newer versions of Stylelint. See also: - https://github.com/stylelint/stylelint/releases/tag/15.8.0 - stylelint/stylelint#6921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6920
No, it's self-explanatory.