Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v8-compile-cache #6907

Merged
merged 1 commit into from Jun 6, 2023
Merged

Remove v8-compile-cache #6907

merged 1 commit into from Jun 6, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6904
Closes #6901

Is there anything in the PR that needs further explanation?

v8-compile-cache no longer has performance benefits on Node.js 20.
Please see the benchmark on #6904 (comment).

`v8-compile-cache` no longer has performance benefits on Node.js 20.
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 0bdc6f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
"stylelint": patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] I think this PR is a non-user-facing change.
See https://stylelint.io/about/semantic-versioning#patch-release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, patch is good for this

@ybiquitous ybiquitous marked this pull request as ready for review June 6, 2023 17:12
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ybiquitous ybiquitous merged commit 1e570f3 into main Jun 6, 2023
13 checks passed
@ybiquitous ybiquitous deleted the issue-6904 branch June 6, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove v8-compile-cache
3 participants