Fix Segmentation fault errors for Cosmiconfig 8.2 #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b4939f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…https://github.com/stylelint/stylelint into fix-cosmiconfig--usage--sensible-dormouse-386f3ffef4
ybiquitous
reviewed
Jun 5, 2023
|
@romainmenke Can you update Cosmiconfig to 8.2 in this PR? Or, do you have any reason not to do it? |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
This PR is set to merge to the dependabot PR that has the Cosmiconfig update. |
ybiquitous
changed the title
Segmentation fault errors
ybiquitous
approved these changes
Jun 5, 2023
ybiquitous
merged commit 83a4698
into
dependabot/npm_and_yarn/cosmiconfig-8.2.0
12 checks passed
ybiquitous
deleted the
fix-cosmiconfig--usage--sensible-dormouse-386f3ffef4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See : #6898
The
syncloaders fromcosmiconfigfor.jsand.cjsstill use the old logic/code.Only the
asyncloaders were changed.Switching back to the
syncloaders makes the errors go away.