Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splitList: boolean to selector-nested-pattern #6896

Merged
merged 3 commits into from Jun 5, 2023

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Jun 5, 2023

Which issue, if any, is this issue related to?

Closes #2430

Is there anything in the PR that needs further explanation?

As @jeddy3 said, we could consider a better name for the option.

#2430 (comment)

(Prehaps there's a better name?. Prior art is the disallowInList option. Spec ref for "list".)

I guess splitList is not bad because selector-disallowed-list rule has similar option.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

🦋 Changeset detected

Latest commit: 33239f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@is2ei Thanks for the pull request! Can you check my reviews?

lib/rules/selector-nested-pattern/index.js Show resolved Hide resolved
@ybiquitous ybiquitous changed the title Add splitList option to selector-nested-pattern rule Add splitList: boolean to selector-nested-pattern Jun 5, 2023
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@ybiquitous ybiquitous merged commit 8f489b0 into stylelint:main Jun 5, 2023
14 checks passed
@ybiquitous ybiquitous mentioned this pull request Jun 5, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add splitList: bool to selector-nested-pattern
2 participants