New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media-feature-name-no-unknown
false positive for not
and or
#6838
Fix media-feature-name-no-unknown
false positive for not
and or
#6838
Conversation
🦋 Changeset detectedLatest commit: 8935e23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…itives-on-types-and-modifiers--compassionate-insect-50ef6d6325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request, and sorry for the late review! I have a question.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…itives-on-types-and-modifiers--compassionate-insect-50ef6d6325
…ypes-and-modifiers--compassionate-insect-50ef6d6325' of https://github.com/stylelint/stylelint into fix-media-feature-name-no-unknown--false-positives-on-types-and-modifiers--compassionate-insect-50ef6d6325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! LGTM 👍🏼
Closes #6834
This update will remove support for any custom syntax in media queries.Before this change this rule would attempt to parseless
,scss
, ... and give warnings on unknown feature names, even when the feature value was non-standard syntax.This is not possible with the other parser.