Fix github formatter for missing final newline
#6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent unexpected string concatenation
🦋 Changeset detectedLatest commit: 604b5b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
konomae
commented
Apr 27, 2023
| }, | ||
| }; | ||
| describe('githubFormatter', () => { | ||
| test('outputs no warnings', () => { |
There was a problem hiding this comment.
Added case with no warnings
konomae
commented
Apr 27, 2023
Comment on lines
+73
to
+74
| ::error file=a.css,line=20,col=3,title=Stylelint problem::Anonymous error | ||
| `); |
There was a problem hiding this comment.
The indentation change makes the modification appear larger, but the only thing that changes the result is the line break here.
konomae
commented
Apr 27, 2023
| }); | ||
| }); | ||
|
|
||
| lines.push(''); |
There was a problem hiding this comment.
This is the only place where the logic has changed.
ybiquitous
changed the title
github formatter for missing final newline
|
Thanks for the review and the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent unexpected string concatenation