Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for Node.js 20 on CI #6806

Merged
merged 13 commits into from
Jun 13, 2023
Merged

Test for Node.js 20 on CI #6806

merged 13 commits into from
Jun 13, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 23, 2023 •
edited

Which issue, if any, is this issue related to?

Ref: #6794

Is there anything in the PR that needs further explanation?

Tests for Node.js 20 are still unstable. We can restore it if they become stable.

Note: CI statuses are different by each environment:

  • ❌ ubuntu
  • ❌ windows
  • ✅ macos

➡️ All green thanks to Jest's --workerIdleMemoryLimit option! 🎉

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023 •
edited

⚠️ No Changeset found

Latest commit: 32a5eda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous ybiquitous added the pr: blocked is blocked by another issue or pr label Apr 23, 2023
@ybiquitous ybiquitous marked this pull request as ready for review April 23, 2023 01:49
@ybiquitous
Copy link
Member Author

Are the failures due to Jest instead of Node.js...? 🤔

@alexander-akait
Copy link
Member

Funny:

Test Suites: 360 passed, 360 total

@ybiquitous
Copy link
Member Author

Trying Jest's --detectOpenHandles option via f7a261f

@ybiquitous ybiquitous marked this pull request as draft June 8, 2023 10:01
@ybiquitous
Copy link
Member Author

--workerIdleMemoryLimit can resolve failures (8d50713)! 🎉

I know the option from this issue: 👇🏼

@ybiquitous ybiquitous mentioned this pull request Jun 8, 2023
Merged
@ybiquitous ybiquitous marked this pull request as ready for review June 8, 2023 14:07
ybiquitous
ybiquitous commented Jun 9, 2023
View reviewed changes
.github/workflows/testing.yml
os: '["ubuntu-latest", "windows-latest", "macos-latest"]'
exclude: '[{"node-version": "18", "os": "ubuntu-latest"}]' # for coverage
# HACK: `--workerIdleMemoryLimit` can avoid failures on Node.js 20. See https://github.com/jestjs/jest/issues/11956
test-options: '--workerIdleMemoryLimit=0.2'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] See below about test-options:

@ybiquitous ybiquitous removed the pr: blocked is blocked by another issue or pr label Jun 10, 2023
@ybiquitous
Copy link
Member Author

CI is now green ✅

@ybiquitous ybiquitous merged commit ffd3119 into main Jun 13, 2023
18 checks passed
@ybiquitous ybiquitous deleted the test-nodejs-20 branch June 13, 2023 12:08
@ybiquitous ybiquitous mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ybiquitous @alexander-akait @ntwb