Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block-no-empty false positives with non-whitespace characters #6782

Merged
merged 1 commit into from Apr 13, 2023
Merged

Fix block-no-empty false positives with non-whitespace characters #6782

merged 1 commit into from Apr 13, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6779

Is there anything in the PR that needs further explanation?

This pull request fixes such false positives for not only the standard CSS but also CSS-in-JS like this:

Standard CSS:

a {
  ;
}

CSS-in-JS:

const Button = styled.button`
  &:hover {
    ${buttonHover}
  }
`;

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

🦋 Changeset detected

Latest commit: 2a433e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous mentioned this pull request Apr 13, 2023
Closed
@ybiquitous ybiquitous marked this pull request as ready for review April 13, 2023 00:14
hudochenkov
hudochenkov approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ybiquitous
Copy link
Member Author

Thanks for the review!

@ybiquitous ybiquitous merged commit 231dac4 into main Apr 13, 2023
14 checks passed
@ybiquitous ybiquitous deleted the issue-6779 branch April 13, 2023 13:59
@hudochenkov hudochenkov mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix block-no-empty false positives with non-whitespace characters
2 participants
@ybiquitous @hudochenkov