Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore: ["consecutive-duplicates-with-different-syntaxes"] to declaration-block-no-duplicate-properties #6772

Merged
merged 12 commits into from Apr 12, 2023
Merged

Add ignore: ["consecutive-duplicates-with-different-syntaxes"] to declaration-block-no-duplicate-properties #6772

merged 12 commits into from Apr 12, 2023

Conversation

kimulaco
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6632

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023 •
edited

🦋 Changeset detected

Latest commit: b81cc23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ybiquitous
ybiquitous approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👍🏼

I commented on a trivial suggestion, but you can also leave it as-is.

lib/rules/declaration-block-no-duplicate-properties/index.js Outdated Show resolved Hide resolved
@ybiquitous ybiquitous self-requested a review April 11, 2023 07:33
romainmenke
romainmenke reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the latest changes @kimulaco
I tested a few more things and spotted two more additions that would make this better :)

lib/rules/declaration-block-no-duplicate-properties/index.js Outdated Show resolved Hide resolved
lib/rules/declaration-block-no-duplicate-properties/index.js Outdated Show resolved Hide resolved
romainmenke
romainmenke approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

ybiquitous
ybiquitous approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@ybiquitous ybiquitous merged commit 34403c1 into stylelint:main Apr 12, 2023
14 checks passed
@kimulaco kimulaco deleted the feat/6632 branch April 12, 2023 14:53
@ybiquitous ybiquitous mentioned this pull request Apr 17, 2023
Closed
HolgerJeromin added a commit to HolgerJeromin/schemastore that referenced this pull request Jun 28, 2023
@HolgerJeromin
Add consecutive-duplicates-with-different-syntaxes to stylelintrc.json
74671b6 
This was added in 
stylelint/stylelint#6772
@HolgerJeromin HolgerJeromin mentioned this pull request Jun 28, 2023
Merged
HolgerJeromin added a commit to HolgerJeromin/schemastore that referenced this pull request Jun 28, 2023
@HolgerJeromin
Add missing ignore entries to stylelintrc.json
27a16df 
They were added in
stylelint/stylelint#5609
stylelint/stylelint#6772
madskristensen pushed a commit to SchemaStore/schemastore that referenced this pull request Jun 30, 2023
@HolgerJeromin
Add missing ignore entries to stylelintrc.json (#3038)
1671c44 
They were added in
stylelint/stylelint#5609
stylelint/stylelint#6772
jmatias pushed a commit to jmatias/schemastore that referenced this pull request Jul 19, 2023
@HolgerJeromin
Add missing ignore entries to stylelintrc.json (SchemaStore#3038)
b2ed1fe 
They were added in
stylelint/stylelint#5609
stylelint/stylelint#6772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@romainmenke romainmenke romainmenke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore: ["consecutive-duplicates-with-different-syntaxes"] to declaration-block-no-duplicate-properties
3 participants
@kimulaco @ybiquitous @romainmenke