Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings for disabled rules #6747

Merged
merged 2 commits into from Mar 30, 2023
Merged

Fix deprecation warnings for disabled rules #6747

merged 2 commits into from Mar 30, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6744

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023 •
edited

🦋 Changeset detected

Latest commit: d3047f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review March 30, 2023 00:43
@ybiquitous ybiquitous mentioned this pull request Mar 30, 2023
Closed
6 tasks
mattxwang
mattxwang approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hopefully this new release helps users manage deprecations better!

re: the title, wondering if there's a cleaner way to explain what this PR does - e.g. using the word "both". I don't think this is a huge concern though / not merge-blocking.

@ybiquitous
Copy link
Member Author

@mattxwang Thanks for the feedback.

re: the title, wondering if there's a cleaner way to explain what this PR does - e.g. using the word "both". I don't think this is a huge concern though / not merge-blocking.

It could be helpful for users if we had a cleaner PR title (also a changelog entry?). 👍🏼
Do you have a good suggestion?

@mattxwang
Copy link
Member

Hm, nothing immediately jumps out at me. A handful of suggestions:

Fix deprecation warnings for disabled rules

or

Fix disabled rules from emitting deprecation warnings

or

Fix deprecated and disabled rules from emitting warnings

It's certainly a challenging PR title to write 😅 any thoughts?

@ybiquitous ybiquitous changed the title Fix deprecated and disabled rules not to warn Fix deprecation warnings for disabled rules Mar 30, 2023
@ybiquitous
Copy link
Member Author

@mattxwang Thank you! I adopted your first suggestion. 👍🏼

@ybiquitous ybiquitous merged commit 804aefc into main Mar 30, 2023
12 checks passed
@ybiquitous ybiquitous deleted the issue-6744 branch March 30, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never warn against deprecated and disabled rules
2 participants
@ybiquitous @mattxwang