Fix *-case|*-unknown false positives for CSS-in-JS template literals
#6666
Conversation
🦋 Changeset detectedLatest commit: a40de25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hudochenkov
force-pushed
the
fix-css-in-js-false-positives
branch
from
290c74e
to
12b44da
Compare
jeddy3
changed the title
*-case|*-unknown false positives for CSS-in-JS template literals
There was a problem hiding this comment.
Thank you! Just some minor nits, otherwise LGTM.
(We're adopting a shorthand for early returns as we often use them in rules.)
Given focus of Stylelint on standard CSS only, and policy to ignore non-standard syntax, I consider this “regression” acceptable as it doesn't break builds or report new violation.
SGTM.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
|
OMG! Check out this PR number: 6666! :) |
Ha, I noticed it too. Nice! It will be another 1111 issues/prs before we see a sequence like that again. |
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Fixes #6659.
All rules has same issues: trying to lint non-standard value. Based on test one rule (
unit-no-unknown) has a “regression”. Since the fix ignores declaration with non-standard values. It means that previous linted declaration with dollar-variables are now ignored as well. Given focus of Stylelint on standard CSS only, and policy to ignore non-standard syntax, I consider this “regression” acceptable as it doesn't break builds or report new violation.