Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript error to export Plugin and RuleContext #6664

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Fix TypeScript error to export Plugin and RuleContext #6664

merged 4 commits into from
Feb 16, 2023

Conversation

henryruhs
Copy link
Contributor

Export types for plugin authoring.

Related to #6662

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: a30aa2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryruhs Thanks for the pull request. npm run lint:types fails. Could you please check it?

I'll add a changeset later; no worries.

@henryruhs
Copy link
Contributor Author

I fixed it, sorry for that

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the errors. I've left a few minor suggestions. Please consider addressing them.

types/stylelint/index.d.ts Show resolved Hide resolved
types/stylelint/index.d.ts Show resolved Hide resolved
types/stylelint/index.d.ts Outdated Show resolved Hide resolved
@ybiquitous ybiquitous changed the title Export types needed for plugin authoring Fix TypeScript error to export Plugin and RuleContext Feb 16, 2023
@henryruhs
Copy link
Contributor Author

Requested changes have been applied

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit 63d29bf into stylelint:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants