Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines.node field to package.json #295

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Add engines.node field to package.json #295

merged 1 commit into from
Jul 4, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jun 19, 2023

Which issue, if any, is this issue related to?

Ref: stylelint/stylelint-config-recommended#195

Is there anything in the PR that needs further explanation?

The engines.node field should be the same as stylelint's engines.node (peer dependency).

"peerDependencies": {
"stylelint": "^15.5.0"
}

The `engines.node` field should be the same as `stylelint`'s `engines.node` (peer dependency).
@ybiquitous ybiquitous marked this pull request as ready for review June 19, 2023 13:10
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattxwang mattxwang merged commit b6f1895 into main Jul 4, 2023
7 checks passed
@mattxwang mattxwang deleted the add-engines-node branch July 4, 2023 19:45
@mattxwang mattxwang mentioned this pull request Jul 4, 2023
mattxwang added a commit that referenced this pull request Jul 4, 2023
- Removed: `stylelint` less than `15.10.0` from peer dependencies
- Changed: updated to [`stylelint-config-recommended@13.0.0`](https://github.com/stylelint/stylelint-config-recommended/releases/tag/13.0.0).
- updated test introduced in #295

---------

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants