Allow calc function interpolation when declaring CSS custom properties. #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelalozano16
force-pushed
the
sasscript-interpolation
branch
from
850f9be
to
9086ade
Compare
|
Thanks! I wonder if we should ignore the custom properties by default, or put this behind an option? |
|
@kristerkari it should always ignore custom properties since these passed through to CSS as-is, for any SassScript interpolation is required. |
|
got it, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example case
--test: calc(#{$c} + 1);,#{$c}is mistakenly identified as an error. Interpolation is used in SassScript to inject dynamic values into a CSS custom property. This allows interpolation when declaring CSS variables.