Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add at-root-no-redundant rule #846

Merged
merged 1 commit into from Sep 14, 2023
Merged

Add at-root-no-redundant rule #846

merged 1 commit into from Sep 14, 2023

Conversation

pamelalozano16
Copy link
Contributor

@pamelalozano16 pamelalozano16 commented Aug 22, 2023 •
edited

Fix (#601).

Goodwine
Goodwine suggested changes Aug 23, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/README.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/README.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/README.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/__tests__/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/__tests__/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant-selector/index.js Outdated Show resolved Hide resolved
@pamelalozano16 pamelalozano16 marked this pull request as ready for review August 23, 2023 22:00
@pamelalozano16 pamelalozano16 changed the title Add at-root-no-redundant-selector rule Add at-root-no-redundant rule Aug 23, 2023
Goodwine
Goodwine approved these changes Aug 28, 2023
View reviewed changes
Copy link

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the remaining comments

src/rules/at-root-no-redundant/README.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant/README.md Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant/__tests__/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant/__tests__/index.js Outdated Show resolved Hide resolved
src/rules/at-root-no-redundant/index.js Outdated Show resolved Hide resolved
@pamelalozano16
Copy link
Contributor Author

pamelalozano16 commented Aug 29, 2023 •
edited

@kristerkari let us know your thoughts please :)

@kristerkari
Copy link
Collaborator

Thanks! I'll need to go through all the new PRs 👍

@kristerkari kristerkari merged commit b9c1a65 into stylelint-scss:master Sep 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristerkari kristerkari kristerkari approved these changes

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pamelalozano16 @kristerkari @Goodwine