Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function-disallowed-list rule #844

Merged
merged 1 commit into from Aug 8, 2023

Conversation

pamelalozano16
Copy link
Contributor

Fix #422

@pamelalozano16 pamelalozano16 changed the title Add function-blacklist rule Add function-disallowed-list rule Aug 7, 2023
@pamelalozano16 pamelalozano16 marked this pull request as ready for review August 7, 2023 18:21
@kristerkari
Copy link
Collaborator

Looks good!

There are still some extra module syntax that we should add testcases for. Have a look at the function-no-unknown rule test cases here:
https://github.com/stylelint-scss/stylelint-scss/blob/master/src/rules/function-no-unknown/__tests__/index.js#L61-L82

@kristerkari
Copy link
Collaborator

kristerkari commented Aug 8, 2023

Oh, I see. The rule does not actually care about the namespace, it just checks the function name.

I guess that it works, but I guess that there is an edge case where you would have the same function name locally and inside a namespace. That should not be too big of a problem tho, and the namespace support can be added later on.

Copy link
Collaborator

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

Thanks for the contribution!

@kristerkari kristerkari merged commit 0f55b3f into stylelint-scss:master Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a lint to ban specific built-in functions
2 participants