Fix at-rule-no-unknown end positions
#655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also adds a test helper function to make testing multiline strings easier.
ybiquitous
commented
Aug 23, 2022
| line: 1, | ||
| column: 1, | ||
| endLine: 1, | ||
| endColumn: 10, |
There was a problem hiding this comment.
[note] It seems to me that one case change is enough to test end positions.
kristerkari
reviewed
Aug 23, 2022
| line: warning.line, | ||
| column: warning.column | ||
| start: { line: warning.line, column: warning.column }, | ||
| end: { line: warning.endLine, column: warning.endColumn }, |
There was a problem hiding this comment.
@ybiquitous is this a backwards compatible change?
There was a problem hiding this comment.
Good point. I tried testing the minimum version of peerDependencies.stylelint locally:
Lines 40 to 42 in efd565d
$ npm i stylelint@14.5.1
...
$ npx jest at-rule-no-unknown --no-verbose
FAIL src/rules/at-rule-no-unknown/__tests__/index.js
● scss/at-rule-no-unknown › reject › [ true ] › '@funciton floo ($n) {}\n' › no description
expect(received).toMatchObject(expected)
- Expected - 2
+ Received + 0
Object {
"column": 1,
- "endColumn": 10,
- "endLine": 1,
"line": 1,
"text": "Unexpected unknown at-rule \"@funciton\" (scss/at-rule-no-unknown)",
}
at Object.<anonymous> (node_modules/jest-preset-stylelint/getTestRule.js:88:33)It seems that the backward compatibility keeps. 👍🏼
If possible, I think it's better to update peerDependencies.stylelint to ^14.7.0, but not required.
kristerkari
approved these changes
Oct 21, 2022
|
Don't mind. Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #652
This change also adds a test helper function to make testing multiline strings easier.