Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(at-import-partial-extension): fixer incorrectly replaces filename #643

Merged
merged 1 commit into from Aug 10, 2022
Merged

bugfix(at-import-partial-extension): fixer incorrectly replaces filename #643

merged 1 commit into from Aug 10, 2022

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Aug 1, 2022

Hi, my first contrib here. 馃憢

While fixing a large codebase I noticed the at-import-partial-extension fixer incorrectly fixed certain files when they have .scss in their filename. (example: component.scss-theme.scss)


currently:
at-import-partial-extension's fixer incorrectly replaced all .scss occurences in a filename.

- @import "component.scss-theme.scss";
+ @import "component-theme";

expected:
at-import-partial-extension's fixer should only replace the .scss extension (not when .scss is used in the filename itself)

- @import "component.scss-theme.scss";
+ @import "component.scss-theme";

@kristerkari
Copy link
Collaborator

Thanks @chimurai ! Looks really good!

@kristerkari kristerkari merged commit 33c1287 into stylelint-scss:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants