Replace enzyme with React testing library #2086
Merged
+1,011
−1,514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary/react. This is required for an upgrade to React 18, which enzyme does not support. I've tried to keep the impact on the tests as small as possible. Shallow snapshot tests use react-test-renderer/shallow.createRenderer Deep snapshot tests use react-test-renderer.create Interaction tests use @testing-library/react.render In snapshots 'class' changed to 'className'. The 'key' property is no longer emitted. Injected HTML is formatted differently (quoted an no newlines). Some tests navigated into the render output to pick out a smaller piece to snapshot. That was too difficult to replicate. There is a problem with the deabsdeep/serializer. It breaks serialization of React Elements, because the map 'loses' the $$typeof marker used by jest's native React serializer. I've copied the serializer code into this project and fixed the problem. In the future we could look at using this serializer selectively for only tests that needs it. deabsdeep library is still used in places, just not the serializer.
ThomasRoest
force-pushed
the
react-18-upgrade
branch
from
cb04705 to
212cf66
Compare
Codecov Report
Additional details and impacted files
|
ThomasRoest
changed the title
|
🎉 This PR is included in version 13.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Enzyme with React Testing library. Enzyme does not support React 18