Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to pick in_progress, waiting or both to be canceled #209

Closed
8666 opened this issue Sep 7, 2023 · 2 comments · Fixed by #210
Closed

Flag to pick in_progress, waiting or both to be canceled #209

8666 opened this issue Sep 7, 2023 · 2 comments · Fixed by #210
Labels
enhancement New feature or request

Comments

@8666
Copy link
Contributor

8666 commented Sep 7, 2023

Bit related to #23

I am fine with canceling runs that are queued (like wait for approval to deploy to protected environment) but not OK to cancel it if it is in progress.

Like multiple merges to main that are deployed to qa/dev but pending prod deployment. I am fine if latest merge cancel previous pending deployments. But if I deploy in prod and someone merges to master a PR it will cancel prod in mid-deployment. That is how native concurrency works in GHA.

Can you add a flag to your action to not cancel in_progress runs?
@styfle styfle added the enhancement New feature or request label Sep 7, 2023
@styfle
Copy link
Owner

styfle commented Sep 7, 2023

Feel free to make a PR

@8666
Copy link
Contributor Author

8666 commented Sep 25, 2023

#210

@styfle styfle linked a pull request Sep 25, 2023 that will close this issue
Add option only_status #210
Merged
@8666 8666 changed the title Flag to pick in_progress, queued or both to be canceled Flag to pick in_progress, waiting or both to be canceled Sep 29, 2023
@styfle styfle mentioned this issue Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option only_status 8666/cancel-workflow-action
2 participants
@styfle @8666