Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (config): Add --allowEmpty option #4198

Merged
merged 3 commits into from
May 21, 2023
Merged

Feat (config): Add --allowEmpty option #4198

merged 3 commits into from
May 21, 2023
+31 −3

Conversation

emir7
Copy link
Contributor

@emir7 emir7 commented May 17, 2023

A potential solution for #4197

@emir7 emir7 changed the title Add --allowEmpty option to configuration Feat (config): Add --allowEmpty option May 17, 2023
nicojs
nicojs requested changes May 20, 2023
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just a small remark.

@nicojs nicojs enabled auto-merge (squash) May 20, 2023 21:15
@nicojs nicojs linked an issue May 20, 2023 that may be closed by this pull request
Allow Stryker to exit without any errors when no tests are found #4197
Closed
@emir7
Copy link
Contributor Author

emir7 commented May 20, 2023 •
edited
Loading

Seems like the tests are failing for some reason on Windows 😅 the error is a little bit odd and is related to the vitest-runner. It prints the following:
Error: EBUSY: resource busy or locked, rmdir 'D:\a\stryker-js\stryker-js\packages\vitest-runner\testResources\tmp\workDir-7081502'
not 100% sure, but it might occur due to the fact that processes aren't fully closed during the test run execution

@nicojs
Copy link
Member

nicojs commented May 21, 2023

Yeah, probably. I think it's a bug in Vitest itself (we're calling and awaiting .close()) We've just merged the Vitest runner and I'm seeing these errors for the first time... I'll restart the builds

@nicojs nicojs merged commit 44e355e into stryker-mutator:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Stryker to exit without any errors when no tests are found
2 participants
@emir7 @nicojs