Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cicd): Add --forbid-only in mocha config #3823

Conversation

Giovds
Copy link
Contributor

@Giovds Giovds commented Oct 30, 2022

Closes #3818

Add the --forbid-only argument to mocha when running tests on the build server to give a more concrete warning when you've accidentally pused a it.only() test.

Before:
https://github.com/stryker-mutator/stryker-js/actions/runs/3347971096/jobs/5546534847#step:5:2780

After:
https://github.com/Giovds/stryker-js/actions/runs/3355540113/jobs/5559880282#step:5:918

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
This reverts commit 89704b5.
@nicojs nicojs merged commit 051ec93 into stryker-mutator:master Oct 30, 2022
@nicojs
Copy link
Member

nicojs commented Oct 30, 2022

Ah this actually wasn't a feature. By marking it as feat it got lumped into the changelog 😅 Fixing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable --forbit-only in CI/CD pipeline
2 participants